mroberts
f5934181ec
Copy the standalone code-review and terraform-review skills into
plugins/reviews as audit-code and audit-terraform. The rename separates the
automated, linter-driven audits from the guided review-pr walkthrough that
already lived here.
Resolve bundled script paths through ${SKILL_DIR}, exported in a new step 0.
CLAUDE_PLUGIN_ROOT is not set in the Bash tool environment, so the obvious
substitution would have expanded to nothing and broken every collection
script invocation.
Replace the PLAN and DESIGN docs with READMEs written from the current
SKILL.md and scripts. The old docs had drifted badly: they named semgrep
where the code calls opengrep, scoped five review agents where there are
now eight, and predated Lua, PowerShell, and GitHub Actions support.
Add CONSISTENCY_NORMS to the audit-terraform agent inputs. The collection
script writes consistency_norms.json and the agent prompt declares it, but
SKILL.md never listed it, leaving the variable unsubstituted.
Drop the --ingest-verdicts instruction from both skills. review_stats.py
parses no arguments, so the ref-mode verdict template it told users to feed
back could never be read.
Point audit-terraform's smoke test at README.md and resolve its fixture
paths relative to the test file rather than an absolute home directory.
Tests: 197 passing (audit-code), 106 passing (audit-terraform).
1.3 KiB
1.3 KiB
fsbp-reviewer agent
Legacy fallback reviewer for AWS Foundational Security Best Practices (FSBP).
This prompt is not part of the default review path anymore. The default flow
uses Trivy for first-pass benchmark-style detection, then aws-bp-reviewer
for contextual triage and gap-finding.
When to use
Use only when explicitly asked to cross-check Trivy findings against FSBP or when the default Trivy-first path needs benchmark-specific confirmation.
Inputs
MANIFEST— agent slice produced bycollect-changes.pyREPO— repo root / worktree pathOUTPUT— path to write findings JSON
Default behavior
- Read
trivy_findingsfromMANIFESTfirst. - Treat Trivy as the source of first-pass benchmark-style detection.
- Only emit an FSBP finding when:
- Trivy surfaced an issue that needs FSBP labeling or confirmation, or
- you find a high-confidence FSBP gap that Trivy clearly missed.
- Do not fetch live docs in the default fallback path unless the user explicitly asked for benchmark confirmation and the needed mapping is absent.
Rules
- Minimize overlap with Trivy and
aws-bp-reviewer. - Do not repeat noisy low-value benchmark checks already present in
trivy_findings. - Write only the JSON findings document to
OUTPUT.